Save single audio file & script when completed in demo app #42
Conversation
There was a problem hiding this comment.
@Kostis-S-Z - looking good. One thing I noticed is that once you click 'save the audio', it removes all the text and audio snippets above. Is there any way we can keep those after the user has clicked save?
Well its a bit tricky. Since we are "streaming" the text and the audio as they being generated, its not trivial to make them persistent after clicking a button goes then you need to re-render them. But if you try to do that it will show up like this
If @daavoo has a magic trick to fix this then I am happy to implement it! |
|
@Kostis-S-Z - Okay no worries if its too tricky, its not essential. |
Have you checked https://docs.streamlit.io/develop/concepts/architecture/fragments ? |
daavoo
force-pushed
the
33-modify-demo-app-to-generate-single-audio-output
branch
from
498e871 to
5940dad
Compare
I will take a look! Would you be okay if we merge this as is for now, and I work on this later in a different PR? I feel like its a bit lower priority right now |
ok, lets consider it a follow-up. I still haven't review the code changes, though |
Kostis-S-Z
deleted the
33-modify-demo-app-to-generate-single-audio-output
branch
What's changing
In the demo app, when the script and audio generation of the whole podcast is complete, we want to save the complete audio as a single audio file and the complete script as a text file. This PR is an implementation of two buttons that enable this feature.
Closes #33
How to test it
Steps to test the changes:
pip install -e .python -m streamlit run demo/app.pypodcast.wavfile is generated under the root directoryscript.txtfile is generated under the root directoryAdditional notes for reviewers
Currently the generated podcast text disappears when you click one of the two buttons.
I already...
/docs)